Open
Conversation
|
7 tasks
Member
Author
|
@copilot fix tests |
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive Pimcore Studio integration for CoreShop, introducing a modern React-based UI to replace the legacy ExtJS interface.
Changes:
- Added complete Studio UI plugin system using React, TypeScript, and Module Federation
- Implemented entity managers for addresses, zones, countries, states, currencies, and other CoreShop resources
- Created rule-based UI components for cart price rules, product price rules, and notification rules
- Established npm workspaces build system with Rsbuild for managing multiple Studio bundles
Reviewed changes
Copilot reviewed 170 out of 1066 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/CoreShop/Bundle/CoreBundle/Controller/CustomerTransformerController.php |
Fixed SQL injection vulnerability by using parameterized query |
src/CoreShop/Bundle/ConfigurationBundle/composer.json |
Updated PHPStan versions and added Pimcore Studio suggestion |
src/CoreShop/Bundle/ClassDefinitionPatchBundle/composer.json |
Updated PHPStan versions and added Pimcore Studio suggestion |
src/CoreShop/Bundle/AddressBundle/composer.json |
Updated PHPStan versions and added Pimcore Studio suggestion |
src/CoreShop/Bundle/AddressBundle/Studio/WebpackEntryPointProvider.php |
Added webpack entry point provider for Studio integration |
src/CoreShop/Bundle/AddressBundle/Resources/translations/* |
Added Studio translations for English and German |
src/CoreShop/Bundle/AddressBundle/Resources/config/services/studio.yml |
Registered Studio webpack entry point provider |
src/CoreShop/Bundle/AddressBundle/Resources/assets/pimcore-studio/**/* |
Complete Studio UI implementation for address management (zones, countries, states) |
src/CoreShop/Bundle/CoreBundle/Resources/assets/pimcore-studio/**/* |
Core Studio UI components including reports, product price rules, cart price rules, notification rules, and customer company assignment |
src/CoreShop/Bundle/CoreBundle/DependencyInjection/CoreShopCoreExtension.php |
Added Studio service loading and data adapter configuration |
package.json |
Root workspace configuration for npm workspaces build system |
rsbuild.studio.config.ts |
Rsbuild configuration wrapper for Studio builds |
docs/**/* |
Updated documentation with Studio UI examples |
config/bundles.php |
Added Pimcore Studio bundles |
config/packages/security.yaml |
Updated security configuration for Studio API routes |
config/packages/pimcore_studio_backend.yaml |
Added Mercure configuration for Studio real-time features |
composer.json |
Added Studio bundle dependencies and suggestions |
.github/workflows/frontend-build.yaml |
Added CI workflow for Studio frontend builds |
.docker/nginx.conf |
Added Mercure proxy configuration and increased FastCGI buffers |
AGENTS.md |
Added repository guidelines for AI agents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.